-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
varaible: fix the new session can't see the instance-level variable store-limit #26649
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: ailinkid <314806019@qq.com>
case variable.TiDBStoreLimit: | ||
var val int64 | ||
val, err = strconv.ParseInt(sVal, 10, 64) | ||
if err != nil { | ||
break | ||
} | ||
storekv.StoreLimit.Store(val) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This switch for if you change a global var, and you want to run code on other TiDB servers. I just wanted to confirm this is the case here?
(I had thought we would not need to add items to this switch, but that's turned out to be wrong. We may need to change SetGlobal()
so that it fires on all TiDB servers).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we need this. the case is that:
statement | Node1 instance | Node2 instance |
---|---|---|
set global | yes(apply local instance) | yes(propagated to instance2) |
set session | yes(apply local instance) | no |
I investigate for a while, maybe this code is actually what I want.
Signed-off-by: ailinkid <314806019@qq.com>
343a931
to
97ea20f
Compare
manual test:
|
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: tangenta <tangenta@126.com>
Co-authored-by: tangenta <tangenta@126.com>
Co-authored-by: tangenta <tangenta@126.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4ccb061
|
@AilinKid: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ailinkid 314806019@qq.com
What problem does this PR solve?
Issue Number: close #26648
What is changed and how it works?
What's Changed: Thanks to Morgan's new framework of variable, the instance variable is more elegant to implement
Check List
Tests
Release note