Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: support date function pushed down to tiflash #26640

Merged
merged 3 commits into from
Aug 5, 2021
Merged

expression: support date function pushed down to tiflash #26640

merged 3 commits into from
Aug 5, 2021

Conversation

mengxin9014
Copy link
Contributor

@mengxin9014 mengxin9014 commented Jul 27, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close ##26639

Problem Summary:

What is changed and how it works?

support date function pushed down to tiflash

What's Changed:
support date function pushed down to tiflash

How it Works:

Tests

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

support function DATE()  pushed down to tiflash

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • hanfei1991

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 27, 2021
@mengxin9014
Copy link
Contributor Author

/run-all-tests

@mengxin9014
Copy link
Contributor Author

/c @LittleFall

@mengxin9014
Copy link
Contributor Author

/c @hanfei1991

@hanfei1991 hanfei1991 self-requested a review July 30, 2021 07:43
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 30, 2021
@LittleFall LittleFall self-requested a review July 30, 2021 07:44
LittleFall
LittleFall approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@LittleFall LittleFall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed status/LGT1 Indicates that a PR has LGTM 1. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 30, 2021
@mengxin9014
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@mengxin9014: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2021
@hanfei1991
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 93a7dd0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2021
@mengxin9014
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit ce429a4 into pingcap:master Aug 5, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 5, 2021
@mengxin9014 @ti-srebot
cherry pick pingcap#26640 to release-5.0
238e387 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 5, 2021
Closed
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #26926

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 5, 2021
@mengxin9014 @ti-srebot
cherry pick pingcap#26640 to release-5.1
958ee37 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 5, 2021
Closed
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #26927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanfei1991 hanfei1991 hanfei1991 approved these changes

@LittleFall LittleFall LittleFall approved these changes

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mengxin9014 @ti-chi-bot @hanfei1991 @ti-srebot @LittleFall