-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpp: check the tiflash availabilities before launching mpp queries. (#26130) #26192
mpp: check the tiflash availabilities before launching mpp queries. (#26130) #26192
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@hanfei1991 you're already a collaborator in bot's repo. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@hanfei1991: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: f4aade0
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run_unit-test |
/run-unit-test |
cherry-pick #26130 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/26192
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close pingcap/tiflash#1807
Problem Summary:
Right now, TiDB's mpp client don't know which tiflash nodes are available before the mpp query starts. Then we adopted a very conservative method that only uses the tiflash nodes executed in the last query. This leads to the problem that if there are at least two tiflash replica for regions, we might not detect the new scale-out tiflash nodes and cannot fully exploit the cluster capibilities.
What is changed and how it works?
What's Changed:
To totally tackle this problem, we sent a "IsAlive" rpc request to every tiflash node before the query is launched. Then we can clearly know which nodes can be used.
Check List
Related Changes:
kvproto pr: pingcap/kvproto#781
client-go pr: tikv/client-go#225
Tests
Release note