Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix some errcheck #25855

Merged
merged 5 commits into from
Jul 16, 2021
Merged

*: fix some errcheck #25855

merged 5 commits into from
Jul 16, 2021

Conversation

wuliuqii
Copy link
Contributor

What problem does this PR solve?

Issue Number: part of #22979

Problem Summary:

What is changed and how it works?

What's Changed: added errcheck

Check List

Tests

  • No code

Release note

  • No release note.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 30, 2021
@ti-chi-bot
Copy link
Member

Welcome @wuliuqii!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@sre-bot
Copy link
Contributor

sre-bot commented Jun 30, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@wuliuqii wuliuqii changed the title fix some errcheck *: fix some errcheck Jun 30, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jun 30, 2021
@tisonkun
Copy link
Contributor

tisonkun commented Jul 3, 2021

@wuliuqii Thanks for your contribution! Would you mind to do a whole check of errcheck instead of fragmented prs?

@wuliuqii
Copy link
Contributor Author

wuliuqii commented Jul 4, 2021

OK,I'll try

@tisonkun
Copy link
Contributor

@wuliuqii Any updates? BTW there is an ongoing effort to restructure tests #26022 , you may be interested in.

@tisonkun tisonkun requested a review from zimulala July 16, 2021 04:28
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well. Anyway I think this PR is good to merge.

@ti-chi-bot
Copy link
Member

@tisonkun: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Well. Anyway I think this PR is good to merge.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2021
@tisonkun tisonkun requested review from disksing and xhebox and removed request for disksing July 16, 2021 06:33
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 16, 2021
@xhebox
Copy link
Contributor

xhebox commented Jul 16, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 745dc8e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 16, 2021
@ti-chi-bot
Copy link
Member

@wuliuqii: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 1f6c669 into pingcap:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants