planner: generate wrong plan when update has subquery

[hawkingrei]

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: close #25658

Problem Summary:

What is changed and how it works?

if finding the subquery in the UPDATE's assignment list, the point_get return null.

What's Changed:

How it Works:

it change plan. the plan is shown below.

Check List

Tests

• Manual test

CREATE TABLE `users` (
  `id` bigint(20) unsigned NOT NULL,
  `name` longtext DEFAULT NULL,
  `age` bigint(20) unsigned DEFAULT NULL,
  `company_id` bigint(20) DEFAULT NULL,
  `manager_id` bigint(20) unsigned DEFAULT NULL,
  `active` tinyint(1) DEFAULT NULL,
  `created_at` datetime(3) DEFAULT NULL,
  `updated_at` datetime(3) DEFAULT NULL,
  `deleted_at` datetime(3) DEFAULT NULL,
  PRIMARY KEY (`id`),
  KEY `idx_users_deleted_at` (`deleted_at`)
);
insert into users(id, company_id, name, updated_at) values(239, 15, 'Company 2 id 15', '2021-03-01 12:12:12.987');
create table companies(id bigint primary key, name longtext default null);
insert into companies values(14, 'Company 1 id 14');
insert into companies values(15, 'Company 2 id 15');
UPDATE `users` SET `company_id`=14,`name`=(SELECT `name` FROM `companies` WHERE companies.id = users.company_id),`updated_at`='2021-04-27 10:28:31.459' WHERE `id` = 239;

Release note

• No release note

[ti-srebot]

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

[rebelice]

/run-check_release_note

[tangenta]

Good job. A question: Is there any strong reason to apply a manual test instead of an integration test?

[bb7133]

Please add some test cases for your change.

[hawkingrei]

@bb7133 @tangenta @AilinKid PTAL

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• AilinKid
• bb7133

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[bb7133]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 74bca01

[bb7133]

@hawkingrei Please try to check if #25658 can be reproduced in v4.0, v5.0 & v5.1, so that we will decide how many branches that backports would be needed.

[hawkingrei]

@hawkingrei Please try to check if #25658 can be reproduced in v4.0, v5.0 & v5.1, so that we will decide how many branches that backports would be needed.

OK

[hawkingrei]

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/label needs-cherry-pick-5.1

[ti-srebot]

cherry pick to release-4.0 in PR #25696

[ti-srebot]

cherry pick to release-5.0 in PR #25697

[ti-srebot]

cherry pick to release-5.1 in PR #25698