Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: push down abs() to TiFlash #24841

Merged
merged 1 commit into from
May 23, 2021
Merged

expression: push down abs() to TiFlash #24841

merged 1 commit into from
May 23, 2021

Conversation

fzhedu
Copy link
Contributor

@fzhedu fzhedu commented May 22, 2021

What problem does this PR solve?

Issue Number: close pingcap/tiflash#1937

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed: push down abs() to tiflash

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

  • push down abs() to TiFlash

@fzhedu fzhedu requested a review from a team as a code owner May 22, 2021 12:55
@fzhedu fzhedu requested review from lzmhhh123 and removed request for a team May 22, 2021 12:55
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2021
@fzhedu fzhedu requested a review from hanfei1991 May 22, 2021 12:55
@fzhedu
Copy link
Contributor Author

fzhedu commented May 23, 2021

/run-check_dev

@fzhedu fzhedu requested a review from a team as a code owner May 23, 2021 06:40
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2021
@zanmato1984
Copy link
Contributor

Please add some fullstack test in tics repo.

@fzhedu
Copy link
Contributor Author

fzhedu commented May 23, 2021

/run-check_dev

zanmato1984
zanmato1984 approved these changes May 23, 2021
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2021
@fzhedu fzhedu merged commit a71586e into pingcap:hanfei/release5.0-hotfix-tiflash-patch May 23, 2021
@ti-srebot ti-srebot mentioned this pull request Jun 18, 2021
Closed
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 18, 2021
@fzhedu @ti-srebot
cherry pick pingcap#24841 to release-5.0
a2a3c55 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fzhedu @zanmato1984 @ti-chi-bot @ti-srebot