Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner/core: remove random test to reduce CI time #24207

Merged
merged 4 commits into from
Apr 23, 2021
Merged

planner/core: remove random test to reduce CI time #24207

merged 4 commits into from
Apr 23, 2021

Conversation

rebelice
Copy link
Contributor

@rebelice rebelice commented Apr 22, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #24206

Problem Summary:

The TestListColumnsPartitionPrunerRandom cost 200+s(total tests need 345s)

We move this random test to utf to reduce CI time.

The utf pr is here

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note

  • No release note

@rebelice rebelice requested a review from a team as a code owner April 22, 2021 10:45
@rebelice rebelice requested review from winoros and removed request for a team April 22, 2021 10:45
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 22, 2021
@rebelice
Copy link
Contributor Author

/cc @qw4990

@ti-chi-bot ti-chi-bot requested a review from qw4990 April 22, 2021 10:46
@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@rebelice
Copy link
Contributor Author

/run-all-tests

zz-jason
zz-jason reviewed Apr 22, 2021
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 22, 2021
@XuHuaiyu
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • zz-jason

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 23, 2021
@XuHuaiyu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 38dffd4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 23, 2021
@ti-chi-bot
Copy link
Member

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

@ti-chi-bot ti-chi-bot merged commit 3708e80 into pingcap:master Apr 23, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 23, 2021
@rebelice @ti-srebot
cherry pick pingcap#24207 to release-5.0
26c3f82 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 23, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #24241

ti-chi-bot pushed a commit that referenced this pull request Jun 22, 2021
@ti-srebot
planner/core: remove random test to reduce CI time (#24207) (#24241)
9030fbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@winoros winoros Awaiting requested review from winoros

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
component/test needs-cherry-pick-release-5.0 size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reduce the execution time of go test -race for package planner/core
6 participants
@rebelice @zhouqiang-cl @XuHuaiyu @ti-chi-bot @ti-srebot @zz-jason