Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: forbid type conversion between varchar and non-varchar (#23688) #23735

Merged
merged 3 commits into from
Mar 31, 2021
Merged

ddl: forbid type conversion between varchar and non-varchar (#23688) #23735

merged 3 commits into from
Mar 31, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 31, 2021 •
edited
Loading

cherry-pick #23688 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23735

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/23735:release-5.0-7d7a2337d97b

What problem does this PR solve?

Issue Number: close #23624

Problem Summary:

The index value format is different between varchar and non-varchar strings. Thus, we need to reorganize index data if we support the change between varchar and non-varchar. Before column type change feature GA, let's forbid such changes.

What is changed and how it works?

What's Changed: Omitted.

How it Works: Omitted.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Breaking backward compatibility

Release note

  • Forbid type conversion between varchar and non-varchar.

@ti-srebot
cherry pick pingcap#23688 to release-5.0
8749407 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested a review from a team as a code owner March 31, 2021 08:18
@ti-srebot ti-srebot requested review from XuHuaiyu and removed request for a team March 31, 2021 08:18
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Mar 31, 2021
Merged
@ti-srebot ti-srebot added compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. component/expression priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.0-cherry-pick labels Mar 31, 2021
@ti-srebot ti-srebot added this to the v5.0.0 ga milestone Mar 31, 2021
@ti-srebot
Copy link
Contributor Author

@tangenta you're already a collaborator in bot's repo.

@tangenta
Copy link
Contributor

/run-common-test tidb-test=pr/1178
/run-integration-common-test tidb-test=pr/1178

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 31, 2021
@tangenta
Copy link
Contributor

/run-unit-test

@tangenta
Copy link
Contributor

#23741

/run-unit-test

@tangenta
Copy link
Contributor

/run-unit-test

@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@tangenta: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zimulala
Copy link
Contributor

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 31, 2021
@wjhuang2016
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wjhuang2016
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 31, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8749407

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2021
@tangenta
Copy link
Contributor

/run-unit-test

@AilinKid
Copy link
Contributor

/lgtm

@tangenta
Copy link
Contributor

/merge

@tangenta
Copy link
Contributor

Need to merge together with https://github.com/pingcap/tidb-test/pull/1178

@zz-jason
Copy link
Member

/run-common-test -tidb-test=pr/1178

@AilinKid
Copy link
Contributor

/run-integration-common-test tidb-test=pr/1178

@zhouqiang-cl
Copy link
Contributor

/merge

@zhouqiang-cl zhouqiang-cl merged commit db4839d into pingcap:release-5.0 Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@AilinKid AilinKid Awaiting requested review from AilinKid

@bb7133 bb7133 Awaiting requested review from bb7133

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@zimulala zimulala Awaiting requested review from zimulala

Assignees

@tangenta tangenta

Labels
cherry-pick-approved Cherry pick PR approved by release team. compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. component/expression priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Milestone
v5.0.0 ga
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-srebot @tangenta @ti-chi-bot @zimulala @wjhuang2016 @zhouqiang-cl @AilinKid @zz-jason