-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix cast function will ignore tht error for point-get key construction (#22869) #23211
executor: fix cast function will ignore tht error for point-get key construction (#22869) #23211
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@AilinKid you're already a collaborator in bot's repo. |
/LGTM |
@zimulala: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
@AilinKid: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@bb7133: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #22869 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/23211
After apply modifications, you can push your change to this PR via:
Signed-off-by: ailinkid 314806019@qq.com
What problem does this PR solve?
Issue Number: close #22839
What is changed and how it works?
What's Changed:
For (batch) point get, the idxVals should exactly equal to the value in the index record. Cast errors like truncate/data-too-long will trim the idxVals value to the short another one, which will lead to unexpected results. Here we force the cast func to return all the errors.
Seems #17245 is doing the same thing, but it is only for the Overflow error.
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Release note