*: refactor ExecuteInternal to return single resultset (#22546) #22655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
|
LGTM |
tiancaiamao
approved these changes
Feb 4, 2021
|
/merge |
1 similar comment
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #22546 to release-5.0-rc
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/22655After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Problem Summary:
Both
ExecuteandExecuteInternalno longer permit multi-statement, but the return type was maintained the same for backward compatibility.This changes
ExecuteInternalto return a single result-set.Update: I've removed
Executefrom this PR, we can handle it in followup PRs.What is changed and how it works?
What's Changed:
This changes the return type of
ExecuteInternalto be a non-array value.All uses of(for future PRs - it does not need to be handled all at once).Executeare changed to useExecuteInternalRelated changes
Check List
Tests
Side effects
Release note