-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: load data statement shoule not be prepared (#21188) #21222
Merged
ti-srebot
merged 7 commits into
pingcap:release-3.0
from
ti-srebot:release-3.0-6910eae2a1d9
Nov 24, 2020
Merged
executor: load data statement shoule not be prepared (#21188) #21222
ti-srebot
merged 7 commits into
pingcap:release-3.0
from
ti-srebot:release-3.0-6910eae2a1d9
Nov 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@ti-srebot you're already a collaborator in bot's repo. |
/build |
jackysp
reviewed
Nov 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
errors.toml should be deleted.
jackysp
reviewed
Nov 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
/approve |
/merge |
jackysp
approved these changes
Nov 24, 2020
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
first-time-contributor
Indicates that the PR was contributed by an external member and is a first-time contributor.
sig/execution
SIG execution
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
type/3.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #21188 to release-3.0
What problem does this PR solve?
tidb throw unexpected error while execute load data statement in prepare statement
Problem Summary:
The current error is:
‘Load data: previous load data option isn't closed normal’。
expected error is:
‘This command is not supported in the prepared statement protocol yet‘
What is changed and how it works?
What's Changed:
add a logic, if there is load data in prepare statement, return error 'ErrUnsupportedPs'
How it Works:
add a logic, if there is load data in prepare statement, return error 'ErrUnsupportedPs'
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
load data local infile 't1.txt' into table t1 fields terminated by '|' ignore 1 lines
[2020/11/22 21:31:11.349 +08:00] [INFO] [conn.go:801] ["command dispatched failed"] [conn=2199023255557] [connInfo="id:2199023255557, addr:127.0.0.1:56357 status:10, collation:utf8_general_ci, user:root"] [command=Prepare] [status="inTxn:0, autocommit:1"] [sql="load data local infile 't1.txt' into table t1 fields terminated by '|' ignore 1 lines"] [txn_mode=OPTIMISTIC] [err="[executor:1295]This command is not supported in the prepared statement protocol yet"]
Side effects
Release note
load data
statement.