executor: fix LEAD and LAG's default value can not adapt to field type #20747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
Closed
ichn-hu
reviewed
Nov 23, 2020
Comment on lines
+682
to
+684
| if err1 == nil { | ||
| defaultExpr = &expression.Constant{Value: res, RetType: aggFuncDesc.RetTp} | ||
| } |
There was a problem hiding this comment.
if err1 not null, the type conversion is failed, just do nothing and go to the normal process
|
@ichn-hu PTAL |
ti-srebot
previously approved these changes
Dec 8, 2020
|
@blueseason Please resolve the conflict. |
SunRunAway
approved these changes
Dec 10, 2020
ti-srebot
approved these changes
Dec 10, 2020
|
/merge |
|
/run-all-tests |
|
@blueseason merge failed. |
|
/merge |
|
/run-all-tests |
|
/run-all-tests |
|
@blueseason merge failed. |
|
/run-all-tests |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
/run-cherry-picker |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Dec 11, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #21665 |
qw4990
pushed a commit
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #11755
Problem Summary: fix LEAD and LAG's default value can not adapt to field type
What is changed and how it works?
convert LEAD/LAG default value to field type
Check List
Tests
Release note