Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: make failpoint-disable before make clean #20428

Merged
merged 3 commits into from
Oct 14, 2020
Merged

*: make failpoint-disable before make clean #20428

merged 3 commits into from
Oct 14, 2020

Conversation

iosmanthus
Copy link
Contributor

Signed-off-by: iosmanthus myosmanthustree@gmail.com

What problem does this PR solve?

make test in TiDB and interrupt will cause some failpoint related files left in the working space. This pull request will try to clean these files before make clean.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • make test and interrupt, then make clean to check all the generated/modified file are reverted.

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM

Release note

  • make failpoint-disable before make clean

@iosmanthus
make failpoint-disable before make clean
bc7cec3 
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@iosmanthus
not to delete parser related dir
8221355 
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
tangenta
tangenta reviewed Oct 13, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 13, 2020
jackysp
jackysp approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 14, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 14, 2020
@jackysp
Copy link
Member

jackysp commented Oct 14, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 14, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit ad94571 into pingcap:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@jackysp jackysp jackysp approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iosmanthus @jackysp @ti-srebot @tangenta