executor: support memory trace for group_concat #20153
Conversation
|
There is no reward for this challenge pull request, so you can request a reward from @b41sh. |
|
There is no reward for this challenge pull request, so you can request a reward from @b41sh. |
1 similar comment
|
There is no reward for this challenge pull request, so you can request a reward from @b41sh. |
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
There is no reward for this challenge pull request, so you can request a reward from @b41sh. |
|
|
|
There is no reward for this challenge pull request, so you can request a reward from @b41sh. |
|
There is no reward for this challenge pull request, so you can request a reward from @b41sh. |
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
/reward 600 |
|
Reward success. |
…illiam0423/tidb into feature/group_concat_mem_trace
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
/cc @mmyj |
|
LGTM |
| } | ||
|
|
||
| func (e *groupConcatDistinctOrder) MergePartialResult(sctx sessionctx.Context, src, dst PartialResult) (memDelta int64, err error) { | ||
| // If order by exists, the parallel hash aggregation is forbidden in executorBuilder.buildHashAgg. | ||
| // So MergePartialResult will not be called. | ||
| return 0, terror.ClassOptimizer.New(mysql.ErrInternal, mysql.MySQLErrName[mysql.ErrInternal]).GenWithStack("groupConcatDistinctOrder.MergePartialResult should not be called") | ||
| } | ||
|
|
||
| // GetDatumMemSize will be called in func_group_concat_test.go |
There was a problem hiding this comment.
how about GetDatumMemSize is used to calculate memory size of types.Datum?
|
@b41sh PTAL~ |
|
LGTM |
|
PTAL @XuHuaiyu |
|
/merge |
|
/run-all-tests |
|
@william0423 merge failed. |
|
/merge |
|
/run-all-tests |
|
@william0423 merge failed. |
|
/run-tics-test |
|
/run-common-test |
|
@william0423, Congratulations, you get 600 in this PR, and your total score is 600 in high-performance challenge program. |
What problem does this PR solve?
Issue Number: close #19737
Problem Summary: Implement memDelta for group_concat function to trace the memory usage of
AggFunc.What is changed and how it works?
What's Changed: Implement memory track for group_concat
AggFunc.Check List
Tests
Release note