session: refine record execution duration metric (#16453) #16561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
zimulala
reviewed
Apr 21, 2020
zz-jason
reviewed
Apr 22, 2020
|
@sre-bot, please update your pull request. |
1 similar comment
|
@sre-bot, please update your pull request. |
…lease-4.0-7106b189df62
|
LGTM |
tiancaiamao
approved these changes
May 20, 2020
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16453 to release-4.0
Signed-off-by: crazycs520 crazycs520@gmail.com
What problem does this PR solve?
Before, the
Execution Durationof Select was not right, it almost only records the time duration ofexecutor.Open.What is changed and how it works?
Refine record execution duration metric.
Related changes
Check List
Tests
Side effects
Release note
SELECTstatement.