Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: support 'SHOW CONFIG' syntax to show configs of PD and TiKV instances #16230

Merged
merged 11 commits into from
Apr 16, 2020
Merged

executor: support 'SHOW CONFIG' syntax to show configs of PD and TiKV instances #16230

merged 11 commits into from
Apr 16, 2020
+72 −1

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 9, 2020 •
edited
Loading

What problem does this PR solve?

Issue Number: close #16229

Problem Summary: support SHOW CONFIG syntax to show configs of PD and TiKV instances

What is changed and how it works?

When processing SHOW CONFIG, the ShowExec fetches all configs from PD and show them to the user.

After this PR:

mysql> show config where type='pd' and name like '%log.file%';
+------+----------------+----------------------+-------+
| Type | Instance       | Name                 | Value |
+------+----------------+----------------------+-------+
| pd   | 127.0.0.1:2379 | log.file.filename    |       |
| pd   | 127.0.0.1:2379 | log.file.max-backups | 0     |
| pd   | 127.0.0.1:2379 | log.file.max-days    | 0     |
| pd   | 127.0.0.1:2379 | log.file.max-size    | 0     |
+------+----------------+----------------------+-------+

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:

Check List

Tests

  • Unit test

@qw4990 qw4990 requested review from a team as code owners April 9, 2020 07:33
@ghost ghost requested review from wshwsh12, francis0407 and a team and removed request for a team April 9, 2020 07:33
@qw4990 qw4990 requested review from XuHuaiyu, SunRunAway and a team and removed request for francis0407 April 9, 2020 07:33
@ghost ghost removed their request for review April 9, 2020 07:34
@codecov
Copy link

codecov bot commented Apr 9, 2020 •
edited
Loading

Codecov Report

Merging #16230 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #16230   +/-   ##
===========================================
  Coverage   80.6839%   80.6839%           
===========================================
  Files           506        506           
  Lines        138025     138025           
===========================================
  Hits         111364     111364           
  Misses        18068      18068           
  Partials       8593       8593

@qw4990 qw4990 requested review from NingLin-P and rleungx April 14, 2020 09:08
@qw4990 qw4990 removed the status/WIP label Apr 14, 2020
@overvenus
Copy link
Member

LGTM

SunRunAway
SunRunAway reviewed Apr 15, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some integration tests?

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 16, 2020

Could you add some integration tests?

One unit test is added. PTAL.

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 16, 2020

/run-unit-test

SunRunAway
SunRunAway approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Apr 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

@qw4990 merge failed.

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 16, 2020

/run-unit-test

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 16, 2020

/run-unit-test

@qw4990 qw4990 merged commit b44f507 into pingcap:master Apr 16, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 16, 2020
@qw4990 @sre-bot
executor: support 'SHOW CONFIG' syntax to show configs of PD and TiKV…
3ca2ddf 
… instances (pingcap#16230)
@sre-bot sre-bot mentioned this pull request Apr 16, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

cherry pick to release-4.0 in PR #16475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@NingLin-P NingLin-P Awaiting requested review from NingLin-P

@rleungx rleungx Awaiting requested review from rleungx

Assignees
No one assigned
Labels
component/config sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support 'SHOW CONFIG' syntax to show configs of PD and TiKV instances
4 participants
@qw4990 @overvenus @sre-bot @SunRunAway