config: support to dynamically update some config items read from PD #14750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
wshwsh12
reviewed
Feb 13, 2020
XuHuaiyu
reviewed
Feb 13, 2020
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
XuHuaiyu
reviewed
Feb 17, 2020
config/config_handler.go
Outdated
| ch.version = version | ||
| logutil.Logger(context.Background()).Info("PDConfHandler update config successfully", | ||
| zap.String("fromVersion", ch.version.String()), zap.String("toVersion", version.String()), | ||
| zap.String("new_config", newConfContent)) |
There was a problem hiding this comment.
s/ newConfContent/ newConf ?
or
We only need to log the changed conf items?
There was a problem hiding this comment.
Now we have no method to check which config items changed, so I log them all.
But I will implement it in the next few PRs.
wshwsh12
reviewed
Feb 17, 2020
wshwsh12
reviewed
Feb 17, 2020
|
/run-all-tests |
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
|
/run-all-tests |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
wshwsh12
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Part II to implement this proposal: #13660.
Wait for #14303.
In this PR, we refine some code about configs and support to dynamically update some configs items read from PD.
What is changed and how it works?
1.1. remove the feature of hot-reloading configs according to HTTP;
1.2. forbid to update some config items according to SQL like
set @key=valCheck List
Tests