-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: set system_time_zone
from systemTZ
(#13934)
#14086
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
135d386
to
35771be
Compare
zz-jason
reviewed
Dec 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AilinKid
reviewed
Dec 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AilinKid
approved these changes
Dec 17, 2019
Your auto merge job has been accepted, waiting for 13951 |
/run-all-tests |
@bb7133 merge failed. |
/merge |
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/server
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #13934 without conflict.
What problem does this PR solve?
This PR tries to close #13894, by setting system variable
system_time_zone
fromsystem_tz
variable inmysql.tidb
table.What is changed and how it works?
A
setSystemTimeZoneVariable()
is added toserver.NewServer()
, which get the value ofsystemTZ
from exported functionGetSystemTZ()
Please notice that this PR doesn't change any other behavior: all time-related calculations are not affected.
Check List
Tests
The scripts described in #13894 is also used for manual tests.
Code changes
Side effects
Related changes
Release note
system_time_zone
is hard-coded asCST
by setting this variable fromsystem_tz
inmysql
.tidb
table.