Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: log last executed prepared stmt when panic (#12905) #12954

Merged
merged 2 commits into from
Oct 28, 2019
Merged

server: log last executed prepared stmt when panic (#12905) #12954

merged 2 commits into from
Oct 28, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Oct 28, 2019 •
edited
Loading

cherry-pick #12905 to 2.1

# Conflicts:
#	server/conn.go
#	server/conn_stmt.go

This change is Reviewable

@lysu
server: log last executed prepared stmt when panic (#12905)
71de9d8 
# Conflicts:
#	server/conn.go
#	server/conn_stmt.go
@lysu lysu added type/enhancement The issue or PR belongs to an enhancement. priority/release-blocker This issue blocks a release. Please solve it ASAP. type/2.1 cherry-pick component/server labels Oct 28, 2019
@lysu
Copy link
Contributor Author

lysu commented Oct 28, 2019

/run-all-tests

jackysp
jackysp reviewed Oct 28, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bb7133
bb7133 approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels Oct 28, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 28, 2019

Sorry @bb7133, you don't have permission to trigger auto merge event on this branch.

@zimulala zimulala merged commit 8e80122 into pingcap:release-2.1 Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@bb7133 bb7133 bb7133 approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@cfzjywxk cfzjywxk Awaiting requested review from cfzjywxk

Assignees
No one assigned
Labels
component/server priority/release-blocker This issue blocks a release. Please solve it ASAP. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lysu @sre-bot @bb7133 @jackysp @zimulala