*: Support hot-reloading option enable-arrow #12621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12621 +/- ##
===========================================
Coverage 79.8577% 79.8577%
===========================================
Files 462 462
Lines 105723 105723
===========================================
Hits 84428 84428
Misses 15013 15013
Partials 6282 6282 |
zz-jason
reviewed
Oct 12, 2019
|
Your auto merge job has been accepted, waiting for 12769 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Improve the usability for the
enable-arrowWhat is changed and how it works?
Support hot-reloading option
enable-arrow.Check List
Tests
step 1: select the current value:
select @@tidb_enable_arrow;step 2: change the value of
tidb_enable_arrowin the config filestep 3: reload the config
curl -X GET http://127.0.0.1:10080/reload-configstep 4: open a new mysql-client, re-select the value:
select @@tidb_enable_arrow;Code changes
Side effects
Related changes
Release note