planner: display cop tasks when explain format is "dot" #12225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zz-jason
reviewed
Sep 17, 2019
Ok, I add it now. |
Codecov Report
@@ Coverage Diff @@
## master #12225 +/- ##
=========================================
Coverage 81.115% 81.115%
=========================================
Files 454 454
Lines 98634 98634
=========================================
Hits 80007 80007
Misses 12865 12865
Partials 5762 5762 |
added 3 commits
September 17, 2019 21:07
|
Your auto merge job has been accepted, waiting for 12250 |
|
/run-all-tests |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.1 failed |
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1 release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @zz-jason PTAL. |
|
@hailanwhu Could you help us to cherry-pick this PR to release 3.0, release 3.1 and release 2.1? |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 7, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-2.1 in PR #16121 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 7, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #16124 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 7, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #16125 |
sre-bot
added a commit
that referenced
this pull request
Apr 8, 2020
sre-bot
added a commit
that referenced
this pull request
Apr 8, 2020
sre-bot
added a commit
that referenced
this pull request
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
(1) In the physical plan tree, if the top node is a
TableReader/IndexLookUpReader/IndexReader, it will not display the cop processes when executingexplain format="dot".(2) Some uses of
fmt.Sprintfare not the best way.What is changed and how it works?
Check List
Tests
(1)
create table t(a int, b int, c int);(2)
explain format="dot" select * from t where a < 2;Code changes
planner/core/common_plan.go prepareTaskDot()