executor: fix baseExecutor'children may not be closed #11570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11570 +/- ##
===========================================
Coverage 81.2298% 81.2298%
===========================================
Files 426 426
Lines 91901 91901
===========================================
Hits 74651 74651
Misses 11894 11894
Partials 5356 5356 |
Codecov Report
@@ Coverage Diff @@
## master #11570 +/- ##
================================================
+ Coverage 81.1964% 81.1988% +0.0024%
================================================
Files 426 426
Lines 91823 91835 +12
================================================
+ Hits 74557 74569 +12
- Misses 11901 11904 +3
+ Partials 5365 5362 -3 |
|
/run-all-tests |
|
@zimulala merge failed. |
|
cherry pick to release-3.0 in PR #11576 |
|
cherry pick to release-2.1 failed |
zimulala
added a commit
to zimulala/tidb
that referenced
this pull request
Aug 3, 2019
sre-bot
pushed a commit
that referenced
this pull request
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When a child close encounters an error, the other children cannot be closed.
What is changed and how it works?
When a child close encounters an error, the other child continues to call close.
Check List
Tests
Related changes