Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv, config: increase pessimistic lock ttl #11499

Merged
merged 3 commits into from
Jul 30, 2019
Merged

store/tikv, config: increase pessimistic lock ttl #11499

merged 3 commits into from
Jul 30, 2019

Conversation

coocood
Copy link
Member

@coocood coocood commented Jul 29, 2019

What problem does this PR solve?

Make the pessimistic transactions less likely to timeout.

What is changed and how it works?

  • Increase pessimistic TTL hard limit to 120s
  • Increase default pessimistic TTL to 40s
  • Add elapsed time to TTL when LockKeys is called for the first time.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@coocood
Copy link
Member Author

coocood commented Jul 29, 2019

@jackysp @lysu @tiancaiamao PTAL

@coocood coocood requested review from lysu, jackysp and tiancaiamao July 29, 2019 06:48
@codecov
Copy link

codecov bot commented Jul 29, 2019 •
edited
Loading

Codecov Report

Merging #11499 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11499   +/-   ##
===========================================
  Coverage   81.6426%   81.6426%           
===========================================
  Files           424        424           
  Lines         92873      92873           
===========================================
  Hits          75824      75824           
  Misses        11678      11678           
  Partials       5371       5371

jackysp
jackysp reviewed Jul 29, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 30, 2019
@tiancaiamao
Copy link
Contributor

/run-all-tests

lysu
lysu approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added require-LGT3 Indicates that the PR requires three LGTM. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jul 30, 2019
@lysu
Copy link
Contributor

lysu commented Jul 30, 2019

/run-all-tests

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented Jul 30, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jul 30, 2019

@coocood merge failed.

@coocood coocood merged commit 444fb8c into pingcap:master Jul 30, 2019
@coocood coocood deleted the increase-pessimistic-ttl branch July 30, 2019 05:31
@sre-bot
Copy link
Contributor

sre-bot commented Jul 30, 2019

cherry pick to release-3.0 failed

@coocood coocood mentioned this pull request Jul 30, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Apr 7, 2020

It seems that, not for sure, we failed to cherry-pick this commit to release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @coocood PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@lysu lysu lysu approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
component/tikv require-LGT3 Indicates that the PR requires three LGTM. sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@coocood @tiancaiamao @lysu @sre-bot @jackysp