store/helper: remove timeout for fetch diagnose from info pd #11352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #11352 +/- ##
==============================================
- Coverage 81.53% 81.2618% -0.2683%
==============================================
Files 424 423 -1
Lines 91408 90201 -1207
==============================================
- Hits 74525 73299 -1226
- Misses 11594 11603 +9
- Partials 5289 5299 +10 |
Codecov Report
@@ Coverage Diff @@
## master #11352 +/- ##
================================================
- Coverage 81.2851% 81.2618% -0.0234%
================================================
Files 423 423
Lines 90399 90201 -198
================================================
- Hits 73481 73299 -182
+ Misses 11612 11603 -9
+ Partials 5306 5299 -7 |
|
cherry pick to release-3.0 in PR #11383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
current timeout for fetch diagnose info from pd is too short for cluster that have many regions.
What is changed and how it works?
remove timeout when we need to get diagnose info even if it's slow
Check List
Tests
Code changes
Side effects
Related changes
This change is