-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: scatter the regions of table when creating them #10980
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| // Copyright 2019 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package ddl | ||
|
|
||
| import ( | ||
| "github.com/pingcap/parser/model" | ||
| "github.com/pingcap/tidb/kv" | ||
| "github.com/pingcap/tidb/tablecodec" | ||
| "github.com/pingcap/tidb/util/logutil" | ||
| "go.uber.org/zap" | ||
| ) | ||
|
|
||
| func splitPartitionTableRegion(store kv.SplitableStore, pi *model.PartitionInfo, scatter bool) { | ||
| // Max partition count is 4096, should we sample and just choose some of the partition to split? | ||
| regionIDs := make([]uint64, 0, len(pi.Definitions)) | ||
| for _, def := range pi.Definitions { | ||
| regionIDs = append(regionIDs, splitRecordRegion(store, def.ID, scatter)) | ||
| } | ||
| if scatter { | ||
| waitScatterRegionFinish(store, regionIDs) | ||
| } | ||
| } | ||
|
|
||
| func splitTableRegion(store kv.SplitableStore, tbInfo *model.TableInfo, scatter bool) { | ||
| regionIDs := make([]uint64, 0, len(tbInfo.Indices)+1) | ||
| if tbInfo.ShardRowIDBits > 0 && tbInfo.PreSplitRegions > 0 { | ||
| // Example: | ||
| // ShardRowIDBits = 5 | ||
| // PreSplitRegions = 3 | ||
| // | ||
| // then will pre-split 2^(3-1) = 4 regions. | ||
| // | ||
| // in this code: | ||
| // max = 1 << (tblInfo.ShardRowIDBits - 1) = 1 << (5-1) = 16 | ||
| // step := int64(1 << (tblInfo.ShardRowIDBits - tblInfo.PreSplitRegions)) = 1 << (5-3) = 4; | ||
| // | ||
| // then split regionID is below: | ||
| // 4 << 59 = 2305843009213693952 | ||
| // 8 << 59 = 4611686018427387904 | ||
| // 12 << 59 = 6917529027641081856 | ||
| // | ||
| // The 4 pre-split regions range is below: | ||
| // 0 ~ 2305843009213693952 | ||
| // 2305843009213693952 ~ 4611686018427387904 | ||
| // 4611686018427387904 ~ 6917529027641081856 | ||
| // 6917529027641081856 ~ 9223372036854775807 ( (1 << 63) - 1 ) | ||
| // | ||
| // And the max _tidb_rowid is 9223372036854775807, it won't be negative number. | ||
|
|
||
| // Split table region. | ||
| step := int64(1 << (tbInfo.ShardRowIDBits - tbInfo.PreSplitRegions)) | ||
| // The highest bit is the symbol bit,and alloc _tidb_rowid will always be positive number. | ||
| // So we only need to split the region for the positive number. | ||
| max := int64(1 << (tbInfo.ShardRowIDBits - 1)) | ||
| for p := int64(step); p < max; p += step { | ||
| recordID := p << (64 - tbInfo.ShardRowIDBits) | ||
| recordPrefix := tablecodec.GenTableRecordPrefix(tbInfo.ID) | ||
| key := tablecodec.EncodeRecordKey(recordPrefix, recordID) | ||
| regionID, err := store.SplitRegion(key, scatter) | ||
| if err != nil { | ||
| logutil.BgLogger().Warn("[ddl] pre split table region failed", zap.Int64("recordID", recordID), zap.Error(err)) | ||
| } else { | ||
| regionIDs = append(regionIDs, regionID) | ||
| } | ||
| } | ||
| } else { | ||
| regionIDs = append(regionIDs, splitRecordRegion(store, tbInfo.ID, scatter)) | ||
| } | ||
| regionIDs = append(regionIDs, splitIndexRegion(store, tbInfo, scatter)...) | ||
| if scatter { | ||
| waitScatterRegionFinish(store, regionIDs) | ||
| } | ||
| } | ||
|
|
||
| func splitRecordRegion(store kv.SplitableStore, tableID int64, scatter bool) uint64 { | ||
| tableStartKey := tablecodec.GenTablePrefix(tableID) | ||
| regionID, err := store.SplitRegion(tableStartKey, scatter) | ||
| if err != nil { | ||
| // It will be automatically split by TiKV later. | ||
| logutil.BgLogger().Warn("[ddl] split table region failed", zap.Error(err)) | ||
| } | ||
| return regionID | ||
| } | ||
|
|
||
| func splitIndexRegion(store kv.SplitableStore, tblInfo *model.TableInfo, scatter bool) []uint64 { | ||
| regionIDs := make([]uint64, 0, len(tblInfo.Indices)) | ||
| for _, idx := range tblInfo.Indices { | ||
| indexPrefix := tablecodec.EncodeTableIndexPrefix(tblInfo.ID, idx.ID) | ||
| regionID, err := store.SplitRegion(indexPrefix, scatter) | ||
| if err != nil { | ||
| logutil.BgLogger().Warn("[ddl] pre split table index region failed", | ||
| zap.Stringer("table", tblInfo.Name), | ||
| zap.Stringer("index", idx.Name), | ||
| zap.Error(err)) | ||
| } | ||
| regionIDs = append(regionIDs, regionID) | ||
| } | ||
| return regionIDs | ||
| } | ||
|
|
||
| func waitScatterRegionFinish(store kv.SplitableStore, regionIDs []uint64) { | ||
| for _, regionID := range regionIDs { | ||
| err := store.WaitScatterRegionFinish(regionID) | ||
| if err != nil { | ||
| logutil.BgLogger().Warn("[ddl] wait scatter region failed", zap.Uint64("regionID", regionID), zap.Error(err)) | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split index region for a common table, Is it expected?
It used to only split a table region for a common table, doesn't split the index regions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emm... Yes, it is expected.