Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak risk in session pool usage in stats sync load #59560

Closed
time-and-fate opened this issue Feb 15, 2025 · 1 comment · Fixed by #59546
Closed

Memory leak risk in session pool usage in stats sync load #59560

time-and-fate opened this issue Feb 15, 2025 · 1 comment · Fixed by #59546
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. impact/leak report/customer Customers have encountered this bug. severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.

Comments

@time-and-fate
Copy link
Member

Bug Report

The exact reproduction steps are still unknown. But we observed memory leaks in production clusters:

Image

The code in question is similar to what we met in #54022:

v7.5.3:

tidb/pkg/statistics/handle/handle_hist.go

Lines 278 to 281 in 3c599cd

if err == nil { // only recycle when no error
sctx.GetSessionVars().StmtCtx.Priority = mysql.NoPriority
h.SPool().Put(se)
}

master:

tidb/pkg/statistics/handle/syncload/stats_syncload.go

Lines 303 to 306 in 72a1145

if err == nil { // only recycle when no error
sctx.GetSessionVars().StmtCtx.Priority = mysql.NoPriority
s.statsHandle.SPool().Put(se)
}

@time-and-fate time-and-fate added severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug. labels Feb 15, 2025
@time-and-fate time-and-fate added affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. and removed may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 may-affects-8.1 may-affects-8.5 labels Feb 15, 2025
@Rustin170506 Rustin170506 mentioned this issue Feb 16, 2025
Merged
13 tasks
@kennedy8312
Copy link

/impact leak

@time-and-fate time-and-fate added the report/customer Customers have encountered this bug. label Feb 17, 2025
@ti-chi-bot ti-chi-bot bot closed this as completed in 9f5f53a Feb 18, 2025
This was referenced Feb 18, 2025
Merged
Merged
Open
@Rustin170506 Rustin170506 mentioned this issue Feb 19, 2025
Merged
13 tasks
@time-and-fate time-and-fate mentioned this issue Feb 19, 2025
Closed
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Feb 19, 2025
@Rustin170506
statistics: add Destroy method and handle session recycling (#59546) (#…
d8d4e74 
…59634)

close #59524, close #59560
This was referenced Feb 20, 2025
Closed
Closed
ti-chi-bot bot pushed a commit that referenced this issue Feb 21, 2025
@ti-chi-bot
statistics: add Destroy method and handle session recycling (#59546) (#…
f5d5373 
…59615)

close #59524, close #59560
ti-chi-bot bot pushed a commit that referenced this issue Feb 21, 2025
@ti-chi-bot
statistics: add Destroy method and handle session recycling (#59546) (#…
afe8788 
…59614)

close #59524, close #59560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. impact/leak report/customer Customers have encountered this bug. severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

statistics: add Destroy method and handle session recycling Rustin170506/tidb
2 participants
@time-and-fate @kennedy8312