Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load region info from pd in batch #51326

Closed
SeaRise opened this issue Feb 26, 2024 · 8 comments · Fixed by #51333 or #51498
Closed

Load region info from pd in batch #51326

SeaRise opened this issue Feb 26, 2024 · 8 comments · Fixed by #51333 or #51498
Assignees
@SeaRise
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. component/pd severity/minor type/bug The issue is confirmed as a bug. type/enhancement The issue or PR belongs to an enhancement.

Comments

@SeaRise
Copy link
Contributor

SeaRise commented Feb 26, 2024 •
edited
Loading

Enhancement

When a table is very large, the number of regions can be significant. Additionally, because TiDB loads region information from PD with single concurrency and one region per request, loading the region information of a large table can be very slow.

related #14320
@SeaRise SeaRise added the type/enhancement The issue or PR belongs to an enhancement. label Feb 26, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 26, 2024

/assign @SeaRise

@SeaRise SeaRise changed the title Load Region Cache in Batch Load Region Info fromin Batch Feb 26, 2024
@SeaRise SeaRise changed the title Load Region Info fromin Batch Load region info from pd in batch Feb 26, 2024
@SeaRise SeaRise mentioned this issue Feb 27, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Mar 1, 2024
@SeaRise
executor: load region info from pd in batch (#51333)
1d24b1c 
close #51326
This was referenced Mar 4, 2024
Merged
Merged
Closed
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 4, 2024

/label affects-7.5

@ti-chi-bot ti-chi-bot bot added the affects-7.5 This bug affects the 7.5.x(LTS) versions. label Mar 4, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 4, 2024

/label affects-7.1

@ti-chi-bot ti-chi-bot bot added the affects-7.1 This bug affects the 7.1.x(LTS) versions. label Mar 4, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 5, 2024

/label bug

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 5, 2024

@SeaRise: The label(s) bug cannot be applied. These labels are supported: fuzz/sqlancer, challenge-program, compatibility-breaker, first-time-contributor, contribution, good first issue, correctness, duplicate, proposal, security, ok-to-test, needs-ok-to-test, needs-more-info, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, needs-cherry-pick-release-7.6, affects-5.4, affects-6.1, affects-6.5, affects-7.1, affects-7.5, affects-7.6, may-affects-5.4, may-affects-6.1, may-affects-6.5, may-affects-7.1, may-affects-7.5, may-affects-7.6.

In response to this:

/label bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 5, 2024

/type bug

@ti-chi-bot ti-chi-bot bot added the type/bug The issue is confirmed as a bug. label Mar 5, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 5, 2024

/untype enhancement

This was referenced Mar 5, 2024
Closed
Closed
@SeaRise SeaRise mentioned this issue Mar 5, 2024
Merged
13 tasks
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 5, 2024

/severity minor

ti-chi-bot bot pushed a commit that referenced this issue Mar 6, 2024
@SeaRise
.*: update client-go (#51498)
6251f39 
close #51326
This was referenced Mar 6, 2024
Closed
Closed
ti-chi-bot bot pushed a commit that referenced this issue Mar 7, 2024
@SeaRise
executor: load region info from pd in batch(#51333) (#51465)
c52c9d7 
close #51326
ti-chi-bot bot pushed a commit that referenced this issue Mar 11, 2024
@SeaRise
executor: load region info from pd in batch(#51333) (#51469)
b3ab907 
close #51326
@windtalker windtalker mentioned this issue Mar 27, 2024
Merged
18 tasks
@you06 you06 mentioned this issue Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeaRise SeaRise

Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. component/pd severity/minor type/bug The issue is confirmed as a bug. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: load region info from pd in batch SeaRise/tidb
.*: update client-go SeaRise/tidb
2 participants
@jebter @SeaRise