Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refractor the way to handle error and warning #48611

Closed
Tracked by #47355
YangKeao opened this issue Nov 15, 2023 · 0 comments · Fixed by #48613
Closed
Tracked by #47355

Refractor the way to handle error and warning #48611

YangKeao opened this issue Nov 15, 2023 · 0 comments · Fixed by #48613
Assignees
@YangKeao
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@YangKeao
Copy link
Member

Enhancement

While I'm trying to refractor rowcodec, tablecodec, codec... package, I found it's hard because we don't have an unified way to handle the errors and warnings. We can use a errctx to store all the flag related with error handling (especially from SQLMode...).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YangKeao YangKeao

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

util/codec,util/errctx,*: add error context, and use it to refactor util/codec YangKeao/tidb
1 participant
@YangKeao