Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hashjoin goroutine leak #39026

Closed
xhebox opened this issue Nov 9, 2022 · 2 comments · Fixed by #39023
Closed

Hashjoin goroutine leak #39026

xhebox opened this issue Nov 9, 2022 · 2 comments · Fixed by #39023
Labels
affects-4.0 This bug affects 4.0.x versions. affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 severity/moderate sig/execution SIG execution type/bug The issue is confirmed as a bug.

Comments

@xhebox
Copy link
Contributor

xhebox commented Nov 9, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

make failpoint-enable
cd executor
go test -run TestRandomPanicConsume -race -v

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)
@xhebox xhebox added type/bug The issue is confirmed as a bug. sig/execution SIG execution affects-4.0 This bug affects 4.0.x versions. affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-3.1 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 labels Nov 9, 2022
@xhebox
Copy link
Contributor Author

xhebox commented Nov 9, 2022 •
edited
Loading

fetchAndBuildHashTable or previously fetchInnerAndBuildHashTable leaked. It is not closed after rs.Close() causing races in testing env.

@xhebox xhebox mentioned this issue Nov 9, 2022
Merged
12 tasks
@xhebox
Copy link
Contributor Author

xhebox commented Nov 9, 2022

Found while reviewing PRs for #38914

ti-chi-bot pushed a commit that referenced this issue Nov 10, 2022
@xhebox
executor: fix hashjoin goleak (#39023)
208478b 
close #39026
This was referenced Nov 10, 2022
Merged
Merged
Merged
Closed
Closed
ti-chi-bot added a commit that referenced this issue Nov 10, 2022
@ti-chi-bot
executor: fix hashjoin goleak (#39023) (#39056)
c53ec0f 
close #39026
ti-chi-bot added a commit that referenced this issue Nov 10, 2022
@ti-chi-bot
executor: fix hashjoin goleak (#39023) (#39055)
cdb6487 
close #39026
ti-chi-bot added a commit that referenced this issue Nov 10, 2022
@ti-chi-bot
executor: fix hashjoin goleak (#39023) (#39054)
5ccc10b 
close #39026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-4.0 This bug affects 4.0.x versions. affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 severity/moderate sig/execution SIG execution type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: fix hashjoin goleak xhebox/tidb
1 participant
@xhebox