Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use net.JoinHostPort to generate host-port part of URI #36112

Closed
D3Hunter opened this issue Jul 12, 2022 · 0 comments · Fixed by #36113
Closed

use net.JoinHostPort to generate host-port part of URI #36112

D3Hunter opened this issue Jul 12, 2022 · 0 comments · Fixed by #36113
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. component/dumpling This is related to Dumpling of TiDB. severity/minor type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

see detailed description in pingcap/tiflow#6249, DM depends on dumping so need to fix it too.

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)
@D3Hunter D3Hunter added type/bug The issue is confirmed as a bug. severity/minor component/dumpling This is related to Dumpling of TiDB. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. labels Jul 12, 2022
@D3Hunter D3Hunter mentioned this issue Jul 12, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Jul 12, 2022
@D3Hunter
db(dumpling): use net.JoinHostPort to generate host-port part of URI (#…
613c5dc 
…36113)

close #36112
This was referenced Jul 12, 2022
Merged
Merged
Merged
ti-chi-bot pushed a commit that referenced this issue Jul 12, 2022
@ti-srebot
db(dumpling): use net.JoinHostPort to generate host-port part of URI (#…
c82d6d7 
…36113) (#36132)

close #36112
ti-chi-bot pushed a commit that referenced this issue Jul 12, 2022
@ti-srebot
db(dumpling): use net.JoinHostPort to generate host-port part of URI (#…
e6c3d7a 
…36113) (#36130)

close #36112
ti-chi-bot pushed a commit that referenced this issue Jul 12, 2022
@ti-srebot
db(dumpling): use net.JoinHostPort to generate host-port part of URI (#…
8c3a06d 
…36113) (#36131)

close #36112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. component/dumpling This is related to Dumpling of TiDB. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

db(dumpling): use net.JoinHostPort to generate host-port part of URI D3Hunter/tidb
1 participant
@D3Hunter