lightning panic when table name in source file and target cluster is different

[glorv]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

provide following source file:

cat test.T.0.sql
insert into T values (1);

manually create target table in target cluster:

create table test.t(id int);

run tidb-lightning with this source file.

The root cause is:

tidb/br/pkg/lightning/restore/tidb.go

Lines 257 to 279 in ab30467

	for _, tbl := range schema.Tables {
	tblInfo, ok := tableMap[strings.ToLower(tbl.Name)]
	if !ok {
	return nil, errors.Errorf("table '%s' schema not found", tbl.Name)
	}
	tableName := tblInfo.Name.String()
	if tblInfo.State != model.StatePublic {
	err := errors.Errorf("table [%s.%s] state is not public", schema.Name, tableName)
	metric.RecordTableCount(metric.TableStatePending, err)
	return nil, err
	}
	metric.RecordTableCount(metric.TableStatePending, err)
	if err != nil {
	return nil, errors.Trace(err)
	}
	tableInfo := &checkpoints.TidbTableInfo{
	ID: tblInfo.ID,
	DB: schema.Name,
	Name: tableName,
	Core: tblInfo,
	}
	dbInfo.Tables[tableName] = tableInfo
	}

We should also check if other logic has similar issue.

The tableName should use tbl.Name instead of tblInfo.Name.O as they may be different if target table is manually create and is different from tbl.Name.

2. What did you expect to see? (Required)

tidb-lightning should import successfully since tidb is case-insensitive

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

v5.3.0

[niubell]

/label affects-5.2