Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for session #26864

Closed
9 tasks done
Tracked by #26022
tisonkun opened this issue Aug 3, 2021 · 2 comments
Closed
9 tasks done
Tracked by #26022

migrate test-infra to testify for session #26864

tisonkun opened this issue Aug 3, 2021 · 2 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@tisonkun
Copy link
Contributor

tisonkun commented Aug 3, 2021 •
edited
Loading

You may try to analyze first and spawn more subtasks on demand (no strict) instead of one big PR handle the whole package which is hard to review.
@tisonkun tisonkun mentioned this issue Aug 3, 2021
Closed
53 tasks
@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 3, 2021
@tisonkun
Copy link
Contributor Author

@morgo @djshow832 I successfully factored out the setup/teardown logic from test suite in #29066 . However, even though I can pass tests with unistore, it's flaky withTiKV.

I can hardly debug the reason and ask for your help. For CI reports, you can see #29018 .

@tisonkun tisonkun removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Oct 25, 2021
@tisonkun tisonkun mentioned this issue Oct 28, 2021
Closed
@tisonkun tisonkun added the type/enhancement The issue or PR belongs to an enhancement. label Feb 17, 2022
@tisonkun
Copy link
Contributor Author

Closed as migrated to GitHub Actions and testify.

@tisonkun tisonkun mentioned this issue May 18, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue May 18, 2022
@tisonkun
session: cleanup check_dev_2 scaffolding (#34768)
d834649 
ref #26864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tisonkun