Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go version to 1.16.4 #22198

Closed
wjhuang2016 opened this issue Jan 6, 2021 · 13 comments
Closed

Upgrade go version to 1.16.4 #22198

wjhuang2016 opened this issue Jan 6, 2021 · 13 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@wjhuang2016
Copy link
Member

wjhuang2016 commented Jan 6, 2021

Development Task

TiDB uses go version 1.13.4 currently. If we want to use the newer version, we need more tests for it.
We have better to discuss what tests we need in this issue.

@wjhuang2016 wjhuang2016 added the type/enhancement The issue or PR belongs to an enhancement. label Jan 6, 2021
@wjhuang2016
Copy link
Member Author

@zz-jason @shuke987 PTAL

@morgo
Copy link
Contributor

morgo commented Jan 11, 2021

I am not a mac user, but I expect users will soon want to build with go 1.16 because of the native M1 support.

@tisonkun
Copy link
Contributor

tisonkun commented May 13, 2021

@wjhuang2016 I'd suggest change the title name to Upgrade Go Version to 1.16 and thus we get it clear.

I know that @CadmusJiang and @zhouqiang-cl are in charge for upgrading Go Version to 1.16 and most of validation works are done manually. Hopefully we get it done in this month and I'd like to use this existing issue as a tracking issue.

Upgrading the whole TiDB stack Go Version including

@CadmusJiang
Copy link

Get go1.16 image: docker pull hub.pingcap.net/pingcap/centos7_golang-1.16:latest

@tisonkun
Copy link
Contributor

tisonkun commented May 21, 2021

@tisonkun
Copy link
Contributor

closed by #24527

other repository upgrade will be tracked in issues linked above.

@tisonkun
Copy link
Contributor

tisonkun commented May 25, 2021

cc @wjhuang2016 PTAL I think this issue can be closed.

@purelind
Copy link
Contributor

@tisonkun @nolouch pd jenkins ci already upgrade go version from 1.13 to 1.16.4 (only branch master)

@zhouqiang-cl zhouqiang-cl changed the title Upgrade go version to 1.16 Upgrade go version to 1.16.4 May 27, 2021
@tisonkun
Copy link
Contributor

@purelind thanks for your information. I've done the code upgrade part.

@purelind
Copy link
Contributor

@tisonkun @Ehco1996 @lance6716 dm jenkins ci already upgrade go version from 1.13 to 1.16.4 (branch master only)

@purelind
Copy link
Contributor

@tisonkun @BusyJay tikv integration test ci already upgrade go version from 1.13 to 1.16.4 (branch master only)

@purelind
Copy link
Contributor

@tisonkun @3pointer @overvenus @amyangfei binlog / br / ticdc ci already upgrade go version from 1.13 to 1.16.4 (branch master only)

@tisonkun
Copy link
Contributor

closed as almost done. Let tidb-operator tracks in pingcap/tidb-operator#3988 by itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

5 participants