Skip to content

Commit

Permalink
forget to continue in the if branch
Browse files Browse the repository at this point in the history
  • Loading branch information
winoros committed Aug 4, 2023
1 parent dc659d9 commit 986025f
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions planner/core/resolve_indices.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ func (p *PhysicalHashJoin) ResolveIndicesItself() (err error) {
for i, j := 0, 0; i < colsNeedResolving && j < len(mergedSchema.Columns); {
if !p.schema.Columns[i].Equal(nil, mergedSchema.Columns[j]) {
j++
continue
}
p.schema.Columns[i] = p.schema.Columns[i].Clone().(*expression.Column)
p.schema.Columns[i].Index = j
Expand Down Expand Up @@ -234,6 +235,7 @@ func (p *PhysicalMergeJoin) ResolveIndices() (err error) {
for i, j := 0, 0; i < colsNeedResolving && j < len(mergedSchema.Columns); {
if !p.schema.Columns[i].Equal(nil, mergedSchema.Columns[j]) {
j++
continue
}
p.schema.Columns[i] = p.schema.Columns[i].Clone().(*expression.Column)
p.schema.Columns[i].Index = j
Expand Down Expand Up @@ -329,6 +331,7 @@ func (p *PhysicalIndexJoin) ResolveIndices() (err error) {
for i, j := 0, 0; i < colsNeedResolving && j < len(mergedSchema.Columns); {
if !p.schema.Columns[i].Equal(nil, mergedSchema.Columns[j]) {
j++
continue
}
p.schema.Columns[i] = p.schema.Columns[i].Clone().(*expression.Column)
p.schema.Columns[i].Index = j
Expand Down Expand Up @@ -732,6 +735,7 @@ func (p *PhysicalLimit) ResolveIndices() (err error) {
for i, j := 0, 0; i < p.schema.Len() && j < p.children[0].Schema().Len(); {
if !p.schema.Columns[i].Equal(nil, p.children[0].Schema().Columns[j]) {
j++
continue
}
p.schema.Columns[i] = p.schema.Columns[i].Clone().(*expression.Column)
p.schema.Columns[i].Index = j
Expand Down

0 comments on commit 986025f

Please sign in to comment.