expression: add setPbCode for Sign Sqrt

Signed-off-by: Fullstop000 <fullstop1005@gmail.com>
pingcap · Nov 11, 2019 · 710b1d2 · 710b1d2
1 parent 69ff2d5
commit 710b1d2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/expression/builtin_math.go b/expression/builtin_math.go
@@ -1233,6 +1233,7 @@ func (c *signFunctionClass) getFunction(ctx sessionctx.Context, args []Expressio
 	}
 	bf := newBaseBuiltinFuncWithTp(ctx, args, types.ETInt, types.ETReal)
 	sig := &builtinSignSig{bf}
+	sig.setPbCode(tipb.ScalarFuncSig_Sign)
 	return sig, nil
 }
 
@@ -1272,6 +1273,7 @@ func (c *sqrtFunctionClass) getFunction(ctx sessionctx.Context, args []Expressio
 	}
 	bf := newBaseBuiltinFuncWithTp(ctx, args, types.ETReal, types.ETReal)
 	sig := &builtinSqrtSig{bf}
+	sig.setPbCode(tipb.ScalarFuncSig_Sqrt)
 	return sig, nil
 }
 

diff --git a/expression/builtin_math_test.go b/expression/builtin_math_test.go
@@ -14,6 +14,7 @@
 package expression
 
 import (
+	"github.com/pingcap/tipb/go-tipb"
 	"math"
 	"math/rand"
 	"runtime"
@@ -602,6 +603,7 @@ func (s *testEvaluatorSuite) TestSign(c *C) {
 		fc := funcs[ast.Sign]
 		f, err := fc.getFunction(s.ctx, s.primitiveValsToConstants(t.num))
 		c.Assert(err, IsNil, Commentf("%v", t))
+		c.Assert(f.PbCode(), Equals, tipb.ScalarFuncSig_Sign)
 		v, err := evalBuiltinFunc(f, chunk.Row{})
 		c.Assert(err, IsNil, Commentf("%v", t))
 		c.Assert(v, testutil.DatumEquals, types.NewDatum(t.ret), Commentf("%v", t))
@@ -665,6 +667,7 @@ func (s *testEvaluatorSuite) TestSqrt(c *C) {
 		fc := funcs[ast.Sqrt]
 		f, err := fc.getFunction(s.ctx, s.primitiveValsToConstants(t.Arg))
 		c.Assert(err, IsNil)
+		c.Assert(f.PbCode(), Equals, tipb.ScalarFuncSig_Sqrt)
 		v, err := evalBuiltinFunc(f, chunk.Row{})
 		c.Assert(err, IsNil)
 		c.Assert(v, testutil.DatumEquals, types.NewDatum(t.Ret), Commentf("%v", t))