store/mockstore/mocktikv: Add mvccGetByKeyNoLock() to avoid double RL…

…ock (#16924)
pingcap · Mar 31, 2021 · 51a5a3d · 51a5a3d
1 parent c660cee
commit 51a5a3d
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/store/mockstore/mocktikv/mvcc_leveldb.go b/store/mockstore/mocktikv/mvcc_leveldb.go
@@ -1669,7 +1669,7 @@ func (mvcc *MVCCLevelDB) MvccGetByStartTS(starTS uint64) (*kvrpcpb.MvccInfo, []b
 		iter.Next()
 	}
 
-	return mvcc.MvccGetByKey(key), key
+	return mvcc.mvccGetByKeyNoLock(key), key
 }
 
 var valueTypeOpMap = [...]kvrpcpb.Op{
@@ -1684,6 +1684,11 @@ func (mvcc *MVCCLevelDB) MvccGetByKey(key []byte) *kvrpcpb.MvccInfo {
 	mvcc.mu.RLock()
 	defer mvcc.mu.RUnlock()
 
+	return mvcc.mvccGetByKeyNoLock(key)
+}
+
+// mvcc.mu.RLock must be held before calling mvccGetByKeyNoLock.
+func (mvcc *MVCCLevelDB) mvccGetByKeyNoLock(key []byte) *kvrpcpb.MvccInfo {
 	info := &kvrpcpb.MvccInfo{}
 
 	startKey := mvccEncode(key, lockVer)