Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tidb operator node selector #855

Merged
merged 3 commits into from
Sep 2, 2019

Conversation

shonge
Copy link
Member

@shonge shonge commented Sep 1, 2019

What problem does this PR solve?

Support tidb-operator to spec nodeSelector, affinity and tolerations.

What is changed and how does it work?

tidb-operator Chart

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Helm charts change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

Support tidb-operator to spec nodeSelector, affinity and tolerations.

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# - key: node-role
# operator: Equal
# value: tidb-operator
# effect: "NoSchedule"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new line at end of file.

{{- with .Values.controllerManager.tolerations }}
tolerations:
{{ toYaml . | indent 8 }}
{{- end }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new line at end of file.

@cofyc
Copy link
Contributor

cofyc commented Sep 2, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor

cofyc commented Sep 2, 2019

/run-e2e-tests

@cofyc cofyc merged commit 098bc51 into pingcap:master Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants