Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix v1.0.0 don't support binlog.drainer.config #775

Merged
merged 2 commits into from
Aug 22, 2019

Conversation

weekface
Copy link
Contributor

What problem does this PR solve?

v1.0.0 don't support binlog.drainer.config, so we should use the old configuration in the stability test

What is changed and how does it work?

Check List

Tests

  • E2E test
  • Stability test

Code changes

  • Has Go code change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

NONE

@weekface
Copy link
Contributor Author

/run-e2e-in-kind

@weekface
Copy link
Contributor Author

/run-e2e-in-kind

@weekface weekface marked this pull request as ready for review August 16, 2019 03:34
@weekface
Copy link
Contributor Author

/run-e2e-in-kind

1 similar comment
@weekface
Copy link
Contributor Author

/run-e2e-in-kind

@sre-bot
Copy link
Contributor

sre-bot commented Aug 22, 2019

cherry pick to release-1.0 in PR #806

@weekface weekface deleted the fix-test-drainer branch August 22, 2019 07:26
yahonda pushed a commit that referenced this pull request Dec 27, 2021
Signed-off-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants