fix PD peer svc update repeatly (#5015) #5122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #5015
What problem does this PR solve?
in #4973, we refactored the logic of PD service update, after that the PD peer service is updated repeatly.
This is because the service get from the cache may lack the
pingcap.com/last-applied-configuration
annotation as it is deleted by a previous reconcile. also see #462tidb-operator/pkg/controller/service_control.go
Line 157 in e97423e
tidb-operator/pkg/controller/equality.go
Line 77 in e97423e
What is changed and how does it work?
Code changes
Tests
check not
pd-peer
service updated log after this fix.Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.