Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scheduler configuration to run tidb-scheduler #4202

Merged
merged 7 commits into from
Oct 14, 2021

Conversation

KanShiori
Copy link
Collaborator

What problem does this PR solve?

Close #4155

What is changed and how does it work?

Use scheduler configuration to run tidb-scheduler, when Kubernetes is larger than v1.19.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • Kubernetes v1.22.1
  • Deploy tidb-scheduler and check if use scheduler configuration
  • Deploy tidb-cluster
  • Kubernetes v1.19.13
  • Deploy tidb-scheduler and check if use scheduler configuration
  • Deploy tidb-cluster
  • Kubernetes v1.18.13
  • Deploy tidb-scheduler and check if use scheduler policy

  • Deploy tidb-cluster

  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Use scheduler configuration to run tidb-scheduler, when Kubernetes is larger than  v1.19

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #4202 (df8f40c) into master (31d004f) will increase coverage by 2.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4202      +/-   ##
==========================================
+ Coverage   61.72%   64.31%   +2.59%     
==========================================
  Files         181      185       +4     
  Lines       19235    21551    +2316     
==========================================
+ Hits        11872    13860    +1988     
- Misses       6216     6427     +211     
- Partials     1147     1264     +117     
Flag Coverage Δ
e2e 36.47% <ø> (?)
unittest 61.72% <ø> (+<0.01%) ⬆️

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind

- --v={{ .Values.scheduler.logLevel }}
{{- if $lgK8sV119 }}
- --config=/etc/kubernetes/scheduler-config.yaml
{{- else }}
- --leader-elect=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only used when Kubernetes version <1.19?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use scheduler configuration when version >= 1.19

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: badbdd8

@ti-chi-bot
Copy link
Member

@KanShiori: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit d025b71 into pingcap:master Oct 14, 2021
@KanShiori KanShiori deleted the scheduler_compatibility branch October 14, 2021 14:09
@csuzhangxc csuzhangxc mentioned this pull request Jul 14, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tidb-scheduler crash in Kubernetes v1.22.1
5 participants