-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use scheduler configuration to run tidb-scheduler #4202
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4202 +/- ##
==========================================
+ Coverage 61.72% 64.31% +2.59%
==========================================
Files 181 185 +4
Lines 19235 21551 +2316
==========================================
+ Hits 11872 13860 +1988
- Misses 6216 6427 +211
- Partials 1147 1264 +117
|
/test pull-e2e-kind |
/test pull-e2e-kind |
d33f506
to
4c02820
Compare
/test pull-e2e-kind |
- --v={{ .Values.scheduler.logLevel }} | ||
{{- if $lgK8sV119 }} | ||
- --config=/etc/kubernetes/scheduler-config.yaml | ||
{{- else }} | ||
- --leader-elect=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only used when Kubernetes version <1.19?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use scheduler configuration when version >= 1.19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: badbdd8
|
@KanShiori: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Close #4155
What is changed and how does it work?
Use scheduler configuration to run tidb-scheduler, when Kubernetes is larger than v1.19.
Code changes
Tests
Deploy tidb-scheduler and check if use scheduler policy
Deploy tidb-cluster
No code
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.