Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit-tests for dm-master/worker failover/scaler/upgrader and some other components #3326

Merged
merged 9 commits into from
Sep 28, 2020

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Sep 27, 2020

What problem does this PR solve?

#2868
Add UT part 2.
supplement for #3310

What is changed and how does it work?

  1. add unit tests for dm-master/worker failover/scaler/upgrader
  2. add unit tests for dmcluster used components, including orphanPodsCleaner, pvcResizer, reclaimPolicyManage

Check List

Tests

  • Unit test
  • E2E test

Code changes

  • Has Go code change

Does this PR introduce a user-facing change?:

NONE

@lichunzhu
Copy link
Contributor Author

Will be able to be reviewed after #3310 is merged.

@codecov-commenter
Copy link

Codecov Report

Merging #3326 into master will increase coverage by 8.31%.
The diff coverage is 67.25%.

@@            Coverage Diff             @@
##           master    #3326      +/-   ##
==========================================
+ Coverage   42.15%   50.46%   +8.31%     
==========================================
  Files         159      159              
  Lines       16436    16511      +75     
==========================================
+ Hits         6928     8333    +1405     
+ Misses       8867     7400    -1467     
- Partials      641      778     +137     
Flag Coverage Δ
#unittest 50.46% <67.25%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@lichunzhu lichunzhu marked this pull request as ready for review September 27, 2020 12:30
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD DanielZhangQD merged commit a7814bd into pingcap:master Sep 28, 2020
@lichunzhu lichunzhu deleted the addUTForDMCluster2 branch September 28, 2020 07:46
cvvz pushed a commit to cvvz/tidb-operator that referenced this pull request Oct 18, 2020
… other components (pingcap#3326)

* add UT for dmcluster configurations and dmapi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants