-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit-tests for dm-master/worker failover/scaler/upgrader and some other components #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… other components
Will be able to be reviewed after #3310 is merged. |
Codecov Report
@@ Coverage Diff @@
## master #3326 +/- ##
==========================================
+ Coverage 42.15% 50.46% +8.31%
==========================================
Files 159 159
Lines 16436 16511 +75
==========================================
+ Hits 6928 8333 +1405
+ Misses 8867 7400 -1467
- Partials 641 778 +137
Flags with carried forward coverage won't be shown. Click here to find out more. |
AstroProfundis
approved these changes
Sep 27, 2020
DanielZhangQD
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
approved these changes
Sep 28, 2020
cvvz
pushed a commit
to cvvz/tidb-operator
that referenced
this pull request
Oct 18, 2020
… other components (pingcap#3326) * add UT for dmcluster configurations and dmapi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#2868
Add UT part 2.
supplement for #3310
What is changed and how does it work?
orphanPodsCleaner
,pvcResizer
,reclaimPolicyManage
Check List
Tests
Code changes
Does this PR introduce a user-facing change?: