Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug that service annotations exposed in tidbcluster #2471

Merged
merged 2 commits into from
May 15, 2020

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented May 14, 2020

What problem does this PR solve?

Close #2455

Does this PR introduce a user-facing change?:

Fix the bug that the service annotations would be exposed in `TidbCluster` specification.

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yisaer
Copy link
Contributor Author

Yisaer commented May 14, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 14, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 14, 2020

@Yisaer merge failed.

@Yisaer
Copy link
Contributor Author

Yisaer commented May 15, 2020

/run-e2e-in-kind

@cofyc cofyc mentioned this pull request May 15, 2020
1 task
@cofyc cofyc merged commit 3e55c17 into pingcap:master May 15, 2020
sre-bot pushed a commit to sre-bot/tidb-operator that referenced this pull request May 15, 2020
Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
@sre-bot
Copy link
Contributor

sre-bot commented May 15, 2020

cherry pick to release-1.1 in PR #2474

cofyc pushed a commit that referenced this pull request May 15, 2020
Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>

Co-authored-by: Song Gao <disxiaofei@163.com>
Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pingcap.com/last-applied-configuration annotation is synced to tc.spec.tidb.service.annotations
4 participants