Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade for TiFlash #2246

Merged
merged 4 commits into from
Apr 22, 2020
Merged

Upgrade for TiFlash #2246

merged 4 commits into from
Apr 22, 2020

Conversation

DanielZhangQD
Copy link
Contributor

What problem does this PR solve?

Upgrade for TiFlash

What is changed and how does it work?

Upgrade for TiFlash

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • Update config for TiFlash and TiFlash statefulset will be rolling updated
    • If PD, TiKV, or TiDB are upgraded, TiFlash will wait for their rolling updates to be done first

Code changes

  • Has Go code change

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

Support upgrading for TiFlash

@DanielZhangQD DanielZhangQD mentioned this pull request Apr 21, 2020
Closed
13 tasks
weekface
weekface reviewed Apr 21, 2020
View reviewed changes
pkg/manager/member/tiflash_upgrader.go Outdated

tc.Status.TiFlash.Phase = v1alpha1.UpgradePhase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are two places to set tc.Status.TiFlash.Phase to Upgrade, can it be merged?

@DanielZhangQD
Copy link
Contributor Author

@weekface comments addressed, PTAL.

@DanielZhangQD
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 22, 2020

Your auto merge job has been accepted, waiting for:

  • 2242

@DanielZhangQD
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 22, 2020

/run-all-tests

@DanielZhangQD
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 22, 2020

/run-all-tests

@sre-bot sre-bot merged commit f6265e0 into pingcap:master Apr 22, 2020
@DanielZhangQD DanielZhangQD deleted the up0 branch April 22, 2020 06:34
@sre-bot sre-bot mentioned this pull request Apr 22, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Apr 22, 2020

cherry pick to release-1.1 in PR #2258

DanielZhangQD added a commit that referenced this pull request Apr 23, 2020
@sre-bot @DanielZhangQD
Upgrade for TiFlash (#2246) (#2258)
183776d 
* remove useless code

* address comments

Co-authored-by: DanielZhangQD <zhanghailong810@aliyun.com>
Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@weekface weekface weekface approved these changes

@cofyc cofyc Awaiting requested review from cofyc

Assignees
No one assigned
Labels
CanMerge needs-cherry-pick-1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielZhangQD @sre-bot @weekface @Yisaer