terraform: fix docker ulimit configuring for latest EKS AMI #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-test |
weekface
previously approved these changes
Dec 17, 2019
tennix
reviewed
Dec 17, 2019
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-test |
|
Comments addressed @weekface @DanielZhangQD @cofyc PTAL again |
cofyc
approved these changes
Dec 18, 2019
|
/run-e2e-test |
|
/run-e2e-test |
2 similar comments
|
/run-e2e-test |
|
/run-e2e-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aylei rayingecho@gmail.com
close #1344
close #1302
The latest AMI of EKS has a break change that it runs containerd as a separate systemd service, for which we have not adjusted the ulimit. Configuring
ulimitfor containers is a more general method, ref: https://docs.docker.com/engine/reference/commandline/dockerd/Tested on AWS with the latest EKS AMI.
Does this PR introduce a user-facing change?: