Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync tikv configmap and start script in controller #1264

Closed
aylei opened this issue Dec 2, 2019 · 0 comments · Fixed by #1330
Closed

sync tikv configmap and start script in controller #1264

aylei opened this issue Dec 2, 2019 · 0 comments · Fixed by #1330

Comments

@aylei
Copy link
Contributor

aylei commented Dec 2, 2019

#1121

Sync the tikv configmap and start-script in controller, an example about syncing these could be found here:

Note:

  • Rolling-update of configmap should be controlled via a strategy field.
  • An integration test case (e2e) should be added to verify this change will not rolling-update the tikv statefulset created before if there's no change in tidbcluster spec.
  • Unlike pump, configuration of TiKV must have schema, because TiKV is written in rust, it's hard to import the schema of TiKV's configuration directly, maybe maintain a go copy is an acceptable idea, for example, hackathon team plainboring did so : https://github.com/plainboring/config_client/blob/master/pkg/tikv/config.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants