Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor optimize on log file collection #16

Merged
merged 5 commits into from
Jul 5, 2018
Merged

Minor optimize on log file collection #16

merged 5 commits into from
Jul 5, 2018
+79 −12

Conversation

AstroProfundis
Copy link
Contributor

Fix various minor issues when collecting log files with tidb-ansible.

TO DO: our root privilege checking procedure should be redesigned and updated.

AstroProfundis and others added 4 commits July 4, 2018 11:39
@AstroProfundis
*: minor optimize of coding style

Verified

This commit was signed with the committer’s verified signature. The key has expired.
AstroProfundis Allen Zhong
GPG key ID: DB94E46EEDEB9AFD
Expired
Verified
Learn about vigilant mode
518fd21
@AstroProfundis
logfiles: fix bugs when collecting log files with ansible

Verified

This commit was signed with the committer’s verified signature. The key has expired.
AstroProfundis Allen Zhong
GPG key ID: DB94E46EEDEB9AFD
Expired
Verified
Learn about vigilant mode
504728a
@AstroProfundis
logfiles: fix wrong checking params when called by ansible

Verified

This commit was signed with the committer’s verified signature. The key has expired.
AstroProfundis Allen Zhong
GPG key ID: DB94E46EEDEB9AFD
Expired
Verified
Learn about vigilant mode
24db250
@AstroProfundis
Merge branch 'master' into minor-optimize

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
3b04f56
@AstroProfundis AstroProfundis force-pushed the minor-optimize branch 2 times, most recently from 9a758c0 to 8f0767f Compare July 4, 2018 13:01
@AstroProfundis
makefile: add script to build release tarball

Verified

This commit was signed with the committer’s verified signature. The key has expired.
AstroProfundis Allen Zhong
GPG key ID: DB94E46EEDEB9AFD
Expired
Verified
Learn about vigilant mode
8cd55f4
ethercflow
ethercflow approved these changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@ethercflow ethercflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ethercflow ethercflow merged commit 7645622 into pingcap:master Jul 5, 2018
@AstroProfundis AstroProfundis deleted the minor-optimize branch July 5, 2018 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethercflow ethercflow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AstroProfundis @ethercflow