Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drainer: fix kafka message limit problem (#1039) #1080

Merged
merged 2 commits into from
Oct 12, 2021
Merged

drainer: fix kafka message limit problem (#1039) #1080

merged 2 commits into from
Oct 12, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1039

What problem does this PR solve?

When we use kafka as downstream, the transaction size exceed 1G can't to transport to downstream.

What is changed and how it works?

  1. Set grpc message limit to IntMax instead of max.Int32.
  2. Add configuration max-message-size in drainer's config.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

Release note

  • Set grpc message limit to IntMax instead of max.Int32. Add configuration max-message-size in drainer's config.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Oct 12, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 12, 2021
Merged
lichunzhu
lichunzhu approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: f5e54c9

@glorv
Copy link
Contributor

glorv commented Oct 12, 2021

/run-all-tests

@lichunzhu
Copy link
Contributor

/run-unit-test

@lichunzhu
Copy link
Contributor

/run-all-tests

1 similar comment
@lichunzhu
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 75683e3 into pingcap:release-5.2 Oct 12, 2021
@lichunzhu lichunzhu linked an issue Apr 13, 2022 that may be closed by this pull request
pump/drainer: binlog can't replicate data any more if filtered binlog exceeds 2G #1156
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees

@lichunzhu lichunzhu

Labels
cherry-pick-approved size/M status/can-merge status/LGT2 status/PTAL type/cherry-pick-for-release-5.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pump/drainer: binlog can't replicate data any more if filtered binlog exceeds 2G
4 participants
@ti-chi-bot @lichunzhu @glorv @nongfushanquan