Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable drainer to purge old incremental backup data on disk #724

Closed
sokada1221 opened this issue Aug 21, 2019 · 1 comment
Closed

Enable drainer to purge old incremental backup data on disk #724

sokada1221 opened this issue Aug 21, 2019 · 1 comment
Assignees
Labels
feature-request This issue is a feature request status/help-wanted

Comments

@sokada1221
Copy link

Feature Request

Is your feature request related to a problem? Please describe:

Currently, incremental backup data needs to be purged manually if drainer is configured to output files to disk.

Describe the feature you'd like:

Implement a retention period feature where drainer automatically purges data that is older than a configured time.
e.g. If 7 days is configured as a retention period, incremental backup data that is older than 7 days is automatically deleted to free up disk space.

Describe alternatives you've considered:

N/A

Teachability, Documentation, Adoption, Migration Strategy:

For example, a new configuration like the following can be added:

# Determines when to remove old data. Effective only if db-type is "file". Defaults to 7d.
retention-time = 30d
@sokada1221 sokada1221 added the feature-request This issue is a feature request label Aug 21, 2019
@suzaku
Copy link
Contributor

suzaku commented Aug 23, 2019

Makes sense. If this feature is added with a new option retention-time, we'd better set the default value to something like -1 which means "Don't delete backup files for me", so that we don't surprise users of older versions.

@suzaku suzaku self-assigned this Jan 9, 2020
suzaku added a commit to suzaku/tidb-binlog that referenced this issue Jan 15, 2020
suzaku added a commit to suzaku/tidb-binlog that referenced this issue Jan 15, 2020
suzaku added a commit to suzaku/tidb-binlog that referenced this issue Jan 15, 2020
@suzaku suzaku closed this as completed in ff59e72 Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request This issue is a feature request status/help-wanted
Projects
None yet
Development

No branches or pull requests

2 participants