Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puller: fix dead lock #1080

Merged
merged 1 commit into from
Mar 12, 2025
Merged

puller: fix dead lock #1080

merged 1 commit into from
Mar 12, 2025

Conversation

lidezhu
Copy link
Collaborator

@lidezhu lidezhu commented Mar 11, 2025

What problem does this PR solve?

Issue Number: close #1081

What is changed and how it works?

  1. We have limited go routines to schedule range request, and they may be blocked on lock ranges.
  2. These ranges may be locked by other stale regions, and the ranges can only be unlocked by doHandleError.
  3. doHandleError may blocked on sending rangeTask, because all the go routines are blocked on lock ranges and cannot handle the new rangeTask.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Mar 11, 2025
@lidezhu
Copy link
Collaborator Author

lidezhu commented Mar 11, 2025

/run-check-issue-triage-complete

Copy link

ti-chi-bot bot commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 12, 2025
Copy link

ti-chi-bot bot commented Mar 12, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-12 01:33:59.843224654 +0000 UTC m=+319595.448753583: ☑️ agreed by asddongmen.

@ti-chi-bot ti-chi-bot bot added the approved label Mar 12, 2025
@ti-chi-bot ti-chi-bot bot merged commit b7754cb into master Mar 12, 2025
10 of 12 checks passed
@ti-chi-bot ti-chi-bot bot deleted the ldz/fix-puller-stuck0311 branch March 12, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

puller get stuck
2 participants