Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli_tls_with_auth: enable_table_across_nodes should be true in mysql after supported #1078

Conversation

wlwilliamx
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #1077

What is changed and how it works?

Remove the check for enable_table_across_nodes being true for the MySQL type in the integration test cli_tls_with_auth.

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2025
@wlwilliamx
Copy link
Collaborator Author

/check-issue-triage-complete

@wlwilliamx
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 11, 2025
Copy link

ti-chi-bot bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 11, 2025
Copy link

ti-chi-bot bot commented Mar 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-11 09:53:51.788233081 +0000 UTC m=+263187.393762009: ☑️ agreed by hongyunyan.

@ti-chi-bot ti-chi-bot bot merged commit 0cbb4ff into pingcap:master Mar 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable_table_across_nodes should be true for mysql type in cli_tls_with_auth test
2 participants